Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor code #249

Merged
merged 4 commits into from
Oct 3, 2024
Merged

fix: refactor code #249

merged 4 commits into from
Oct 3, 2024

Conversation

ponkio-o
Copy link
Owner

@ponkio-o ponkio-o commented Oct 3, 2024 •
edited
Loading

This PR contains some refactoring:

  • Fixed pagination logic to use DescribeInstancesPaginator to get instance list
  • Using helper func to extract Instance profile and Name tag
  • Fixed EC2Instance struct to use types packages provided by aws-sdk-go-v2

@ponkio-o ponkio-o self-assigned this Oct 3, 2024
@ponkio-o ponkio-o changed the title refactor refactor code Oct 3, 2024
@ponkio-o ponkio-o changed the title refactor code fix: refactor code Oct 3, 2024
@ponkio-o ponkio-o merged commit 4139eeb into main Oct 3, 2024
2 checks passed
@ponkio-o ponkio-o deleted the refactor-1 branch October 3, 2024 16:17
@ec2x-releaser ec2x-releaser bot mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ponkio-o ponkio-o

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ponkio-o