-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factory contracts and sync engine upgrades #361
Conversation
🦋 Changeset detectedLatest commit: 6f68c30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fdeef49
to
1d572da
Compare
bug report on const event = parseAbiItem("event NewNft(address pair, address nft)");
export const config: Config = {
networks: [network],
contracts: [
{
network: network.name,
name: "LSSVMPair",
abi: "./abis/LSSVMPair.json",
startBlock: factoryConfig.startBlock,
factory: {
address: factoryConfig.address,
event,
parameter: "pair",
},
},
{
network: network.name,
name: "NFT",
abi: "./abis/NFT.json",
startBlock: factoryConfig.startBlock,
factory: {
address: factoryConfig.address,
event,
parameter: "nft",
},
},
],
}; if i change the order of the contracts, it's always the first one that has its handlers invoked (i'm destroyng the ponder cache between runs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR introduces factory contract support and makes some improvements to the sync cache design.
WARNING
How to test
pnpm create ponder@next
pnpm upgrade @ponder/core@next
(be warned, this will bust your local sync cache)Fixes