Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: indexing store array parsing #1514

Merged
merged 2 commits into from
Feb 13, 2025
Merged

fix: indexing store array parsing #1514

merged 2 commits into from
Feb 13, 2025

Conversation

kyscott18
Copy link
Collaborator

Closes #1484

@kyscott18 kyscott18 requested a review from typedarray February 13, 2025 00:22
typedarray
typedarray approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@typedarray typedarray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM cc @shrugs

@kyscott18 kyscott18 merged commit e5575df into main Feb 13, 2025
6 checks passed
@kyscott18 kyscott18 deleted the kjs/array-parsing branch February 13, 2025 00:25
@github-actions github-actions bot mentioned this pull request Feb 13, 2025
Merged
tk-o added a commit to namehash/ensnode that referenced this pull request Feb 13, 2025
@tk-o
fix(ponder-schema): replace temporary workaround
26d0923 
Use the original schema field type following the fix released by the Ponder team in ponder-sh/ponder#1514
@shrugs shrugs mentioned this pull request Feb 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typedarray typedarray typedarray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.text().array() parsing issues with strings that have backslash literals
2 participants
@kyscott18 @typedarray