Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend/invites #503

Merged
merged 6 commits into from
Jun 7, 2024
Merged

Backend/invites #503

merged 6 commits into from
Jun 7, 2024

Conversation

Quat3rnion
Copy link
Contributor

  • Adds implementation to convert Guild to InviteGuild
  • Adds GetInviteSchema
  • Replaces primitives with distinct types on InviteGuild

@Quat3rnion Quat3rnion added Status: Review Needed Type: Enhancement Enhances an existing feature or behaviour. labels Jun 5, 2024
@Quat3rnion
Copy link
Contributor Author

forgot to include this in the last pr, oops

@bitfl0wer
Copy link
Member

Still recovering from my sickness + taking a few days of break time after merging that big pr yesterday, so I might not review this in time, unless it is urgent. Is that okay?

kozabrada123
kozabrada123 approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@kozabrada123 kozabrada123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have a minor suggestion for the docs of the schema though :D

@kozabrada123
Copy link
Member

Still recovering from my sickness + taking a few days of break time after merging that big pr yesterday, so I might not review this in time, unless it is urgent. Is that okay?

Dw, take all the time you need

@Quat3rnion @kozabrada123
Update docs aesthetics
83a8f08 
Co-authored-by: kozabrada123 <[email protected]>
@kozabrada123 kozabrada123 merged commit 3237db7 into polyphony-chat:dev Jun 7, 2024
5 checks passed
@kozabrada123 kozabrada123 mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozabrada123 kozabrada123 kozabrada123 approved these changes

@bitfl0wer bitfl0wer Awaiting requested review from bitfl0wer

Assignees
No one assigned
Labels
Type: Enhancement Enhances an existing feature or behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Quat3rnion @bitfl0wer @kozabrada123