QoL Updates #452
Merged
QoL Updates #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Register/login used to require ownership of `instance`. This wasn't really necessary and has been changed.
Register and login, for some reason, required ownership of the `Instance` object. This was not necessary and has been changed in this PR. The PR also includes some extra tests, like logging in, logging in with a token, etc.
Add some sensible implementations for PartialEq, Eq, etc. where I found them to be necessary
Closes #449. + `Instance::from_root_url(root_url: &str, limited: bool)`: Creates a new Instance by trying to get the relevant instance urls (UrlBundle) from a root url. Shorthand for `Instance::new(UrlBundle::from_root_domain(root_domain).await?)` + `UrlBundle::from_root_url(url: &str)`: Performs a few HTTP requests to try and retrieve a UrlBundle from an instance's root URL. The method tries to retrieve the UrlBundle via these three strategies, in order: - GET: $url/.well-known/spacebar -> Retrieve UrlBundle via $wellknownurl/api/policies/instance/domains - GET: $url/api/policies/instance/domains - GET: $url/policies/instance/domains The URL stored at .well-known/spacebar is the instance's API endpoint. The API stores the CDN and WSS URLs under the $api/policies/instance/domains endpoint. If all three of the above approaches fail, it is very likely that the instance is misconfigured, unreachable, or that a wrong URL was provided. + Add clippy warnings for: `clippy::todo, clippy::unimplemented, clippy::dbg_macro, clippy::print_stdout, clippy::print_stderr`
| let limits_configuration = ChorusRequest::get_limits_config(&urls.api).await?.rate; | ||
| let limits = ChorusRequest::limits_config_to_hashmap(&limits_configuration); | ||
| limits_information = Some(LimitsInformation { | ||
| /// Creates a new [`Instance`] from the [relevant instance urls](UrlBundle), where `limited` is whether Chorus will track and enforce rate limits for this instance. |
There was a problem hiding this comment.
where
limitedis whether Chorus will track and enforce rate limits for this instance.
Note: this doc comment is now out of date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib.rsUrlBundlefrom.well-known#449Instance::newin favour of dynamic instance limit checking Automatically check whetherInstanceis rate limited #450