Round-trip nil byte slices correctly. #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@warpfork any word here? If I fix the 1.1 issue, would you take this PR, or should I workaround in on my end? |
|
Okay, apologies for latency. I looked at this once, got scared because I wasn't sure if anything was relying on the previous/wrong behavior, and then closed the tab and forgot about it. I am a monster. I'm looking at it again with fresh eyes now and yes, this is clearly correct, and thank you for making the PR! It seems I've made other changes in the meanwhile so there's now a conflict blocking merge, but it rebases trivially, so... I'll do that and merge the rebase to master momentarily. I'm not sure if github UI will understand, so I might "close" the PR after that, but the credit is definitely yours :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27