-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setup.py #1
Conversation
After doing much more research on this i found out that its an issue of conflicts between breaking changes of 3.7 and 3.6 upgrades from the luciddream author. Now his alterations won't work on colab because of changes to colab. I was able to get it to build locally in colab once i changed the kernel to 3.6 but not work fully and i can't get it to build in 3.7 yet with my changes. Still working on it. Making the py version explicit in the setup.py seemed to help. 1.15 tf cannot be used in 3.7 is the main issue now, and SG2-ADA cannot use 1.14. Thus to get everything working again one would have to revert back to the 3.6 version of the working repo and make the colab comply to the older downgrades. |
Sorry did not see this pull request! Merging now |
Your currently aimed at the outdated repo that is breaking the colabs for the old LSD repo.
This change allows self referencing so you can get your mods to get it working again to work around the broken reference to the original parent fork.
Please accept this pull request to modify your py file or, alternatively, change yours.
This way you can accept your dependancies and not go via that repo's bad deps. He is unresponsive in my attempts to fix his repo, I was hoping to help fix the site, you guys would accept this pull request if it fixes the issue.
I also noticed you are calling TF 1, but also calling PY 3. This may be an issue due to deps with breaking changes.
Also, one other thing was that if you dont specify the specific version numbers with == it assigns newest usually for the py 2 or 3 version. If we specify the specific versions the original LSD or the XL new one you guys made has we can get it to stick to the right dependencies without dealing with the breaking changes.
We may need to make a dual config option based on if you want to use ADA/XL or the original SG2, because they require different versions of TF and Py i believe.
Correct me if i am wrong on any points above, thanks!