Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor logic to better use prefix #491

Merged
merged 2 commits into from
Jun 25, 2021
Merged

Refactor logic to better use prefix #491

merged 2 commits into from
Jun 25, 2021

Conversation

joelamouche
Copy link
Contributor

@joelamouche joelamouche commented Jun 23, 2021 •
edited
Loading

  • use prefix constant
  • ethereum wallet will not provide genesis so must be handled differently
    • necessary for qr import fix

This was referenced Jun 23, 2021
Closed
Merged
@joelamouche
Copy link
Contributor Author

@jacogr ready for review

jacogr
jacogr approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@jacogr jacogr merged commit 7845091 into polkadot-js:master Jun 25, 2021
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacogr jacogr jacogr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joelamouche @polkadot-js-bot @jacogr