substrate connect - upgrade to 0.5.0 #6958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wirednkod
changed the title
jacogr
reviewed
Feb 9, 2022
packages/react-api/src/Api.tsx
Outdated
| @@ -7,7 +7,7 @@ import type { ChainProperties, ChainType } from '@polkadot/types/interfaces'; | |||
| import type { KeyringStore } from '@polkadot/ui-keyring/types'; | |||
| import type { ApiProps, ApiState } from './types'; | |||
|
|
|||
| import { Detector } from '@substrate/connect'; | |||
| import { ScProvider, SupportedChains } from '@substrate/connect'; | |||
There was a problem hiding this comment.
Would prefer -
import type { SupportedChains } from '@substrate/connect';
import { ScProvider } from '@substrate/connect';
jacogr
approved these changes
Feb 9, 2022
|
Thank you very much. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest version of Substrate-connect (0.5.0) has some several changes to the public API and exposed classes.
The changes on the integration with PolkadotJS Apps is fairly easy and straightforward.