Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken Block Details for blocks/chains with V1 Weight #11225

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

ap211unitech
Copy link
Contributor

📝 Description

The Block Details tab in the explorer throws an error for chains still using V1Weight, and all chains if looking up an old block that still used V1.

The error thrown is-

Uncaught error. Something went wrong with the query and rendering of this component. Please supply all the details below when logging an issue, it may help in tracing the cause.

C.proofSize.toBn is not a function

TypeError: C.proofSize.toBn is not a function
at https://polkadot.js.org/apps/page.bb5be2985ccc3806.js:898:7854
at _i (https://polkadot.js.org/apps/modu.bd8f3266470441f0.js:2:77446)
at Ol (https://polkadot.js.org/apps/modu.bd8f3266470441f0.js:2:89067)
at _l (https://polkadot.js.org/apps/modu.bd8f3266470441f0.js:2:88275)
at El (https://polkadot.js.org/apps/modu.bd8f3266470441f0.js:2:87880)
at _u (https://polkadot.js.org/apps/modu.bd8f3266470441f0.js:2:137602)
at ws (https://polkadot.js.org/apps/modu.bd8f3266470441f0.js:2:123430)
at ys (https://polkadot.js.org/apps/modu.bd8f3266470441f0.js:2:123358)
at vs (https://polkadot.js.org/apps/modu.bd8f3266470441f0.js:2:123221)
at is (https://polkadot.js.org/apps/modu.bd8f3266470441f0.js:2:120028)

🤔 Previous behavior

image image image

✅ Current behavior

Screen.Recording.2025-01-22.at.13.36.42.mov

@ap211unitech ap211unitech self-assigned this Jan 22, 2025
@ap211unitech ap211unitech linked an issue Jan 22, 2025 that may be closed by this pull request
@ap211unitech ap211unitech requested a review from TarikGul January 22, 2025 08:22
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing Job!

@TarikGul TarikGul merged commit ce336a6 into master Jan 22, 2025
5 checks passed
@TarikGul TarikGul deleted the fix/broken-block-details branch January 22, 2025 12:37
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block Details broken for blocks/chains with V1 Weight
3 participants