Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend GenericAccountId description #6072

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Extend GenericAccountId description #6072

merged 1 commit into from
Jan 22, 2025

Conversation

valentinfernandez1
Copy link
Contributor

When creating an Account using an empty value such as undefined, [], "", etc. The resulting account is "0x00..000".

This PR further clarifies it by adding this description to the GenericAccountId documentation to avoid confusion. Should address #5697

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 👍

@TarikGul TarikGul merged commit 42c0b2d into master Jan 22, 2025
4 checks passed
@TarikGul TarikGul deleted the docs/empty-account branch January 22, 2025 13:51
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants