TransactionExtension, ExtrinsicV5

[TarikGul]

ref: paritytech/polkadot-sdk#3685

ExtrinsicV4

• Signed Transactions Work
• Unsigned Transaction Work
• No breaking Changes
  • Ensure there are no breaking changes in the current extrinsic construction workflow. This should only be checked off when this PR is ready to be merged.

ExtrinsicV5

• Signed Transactions Work
  • All payloads are hashed with blake2b
  • Encodes signing payload correctly
  • Decodes signing payload correctly
  • Constructs and injects signatures correctly
  • Correctly sets the preamble
  • Correctly sets the Transaction Extension Version
  • Tests
• General Transaction Work
  • Decode
  • Encode
  • Compatibility with ExtrinsicBase
• Bare Transaction Work

Tested Manually

• Succesfully build and send a TX from scratch using createType with Preamble and Version options
• Succesfully build and send a TX from scratch using createType WITHOUT Preamble and Version options
• Submission through api.tx works
• Apps can decode all tx's in explorer
• Substrate-api-sidecar decodes blocks correctly

[bee344]

Something strange happens when I submit a general throught txwrapper: In the terminal I get

Error: 1002 Verification Error: Runtime error: Execution failed: Execution aborted due to trap: wasm trap: wasm unreachable instruction executed
WASM backtrace:
error while executing at wasm backtrace:
    0: 0x6894f9 - rococo_runtime.wasm!rust_begin_unwind
    1: 0x12111 - rococo_runtime.wasm!core::panicking::panic_fmt::h791724d28dc2b8fe
    2: 0x5ac45a - rococo_runtime.wasm!TaggedTransactionQueue_validate_transaction: "RuntimeApi(\"Execution failed: Execution aborted due to trap: wasm trap: wasm unreachable`instruction executed\\nWASM backtrace:\\nerror while executing at wasm backtrace:\\n    0: 0x6894f9 - rococo_runtime.wasm!rust_begin_unwind\\n    1: 0x12111 - rococo_runtime.wasm!core::panicking::panic_fmt::h791724d28dc2b8fe\\n    2: 0x5ac45a - rococo_runtime.wasm!TaggedTransactionQueue_validate_transaction\")"
    at /home/bee344/Documentos/parity/txwrapper-core/packages/txwrapper-examples/lib/txwrapper-examples/common/util.js:33:19
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async main (/home/bee344/Documentos/parity/txwrapper-core/packages/txwrapper-examples/lib/txwrapper-examples/polkadot/src/polkadot.js:110:26)

But when I submit the same hex through apps author.submitExtrinsic I get

1011: Unknown Transaction Validity: UnknownTransaction::NoUnsignedValidator

No idea why though.

Tested with https://github.com/paritytech/txwrapper-core/tree/anp-test-transaction-ext . Last two commits work with the last two commits here, but for some reason general doesn't work with signed and viceversa

[gui1117]

AFAICT NoUnsignedValidator is only possible to be returned by bare extrinsic.

[bkontur]

probably, related to this, see comment: paritytech/polkadot-sdk#3685 (review)

[TarikGul]

probably, related to this, see comment: paritytech/polkadot-sdk#3685 (review)

Yup this will be released today, so we should be able to push this forward to zombienet after!

[TarikGul]

Small merging update - we found a small issue with how api.tx handles the calls. Looking into it (still planning on release today)

[bkontur]

probably, related to this, see comment: paritytech/polkadot-sdk#3685 (review)

cool, looks like this is working so far,
could you please also release api-cli with this change https://github.com/polkadot-js/tools/tree/master/packages/api-cli ?

[TarikGul]

probably, related to this, see comment: paritytech/polkadot-sdk#3685 (review)

cool, looks like this is working so far, could you please also release api-cli with this change https://github.com/polkadot-js/tools/tree/master/packages/api-cli ?

Yup, jumping into it now :)

[polkadot-js-bot]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.