Support ExitError::InvalidCode in gas estimation
#840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tgmichel it would be nice if you could mention who reported this issue ;) |
sorpaas
approved these changes
Sep 4, 2022
Absolutely. I'm sorry but I'm not aware of who reported it the moonbeam dev-rel team, did you? |
tgmichel
added a commit
to moonbeam-foundation/frontier
that referenced
this pull request
Sep 5, 2022
* Pin evm * Support `InvalidCode` in gas estimation * Add ts test * EOF new line (cherry picked from commit 233173e) # Conflicts: # Cargo.lock # client/rpc/Cargo.toml # frame/ethereum/Cargo.toml # frame/evm/Cargo.toml # frame/evm/test-vector-support/Cargo.toml # primitives/evm/Cargo.toml
|
@tgmichel |
abhijeetbhagat
pushed a commit
to web3labs/frontier
that referenced
this pull request
Jan 11, 2023
* Pin evm * Support `InvalidCode` in gas estimation * Add ts test * EOF new line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With latest evm, gas estimation with binary search does not correctly handle
InvalidCode. This PR fixes that, and prevents the binary search to be interrupted on that case.Reported by @AMIRKHANEF