Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(python): Specify that the key column must be sorted in ascending order in merge_sorted #21501

Merged
merged 1 commit into from
Feb 27, 2025
Merged

docs(python): Specify that the key column must be sorted in ascending order in merge_sorted #21501

merged 1 commit into from
Feb 27, 2025

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Feb 27, 2025 •
edited
Loading

Closes #21464

@Matt711 Matt711 mentioned this pull request Feb 27, 2025
Closed
2 tasks
@Matt711 Matt711 changed the title docs(python): Specify that the key column must be sorted in ascending… docs(python): Specify that the key column must be sorted in ascending order in merge_sorted Feb 27, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars and removed title needs formatting labels Feb 27, 2025
ritchie46
ritchie46 approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Matt711

@codecov Codecov
Copy link

codecov bot commented Feb 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.66%. Comparing base (823bfc9) to head (09f6e91).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #21501      +/-   ##
==========================================
- Coverage   79.73%   79.66%   -0.07%     
==========================================
  Files        1605     1605              
  Lines      230053   230053              
  Branches     2623     2623              
==========================================
- Hits       183424   183278     -146     
- Misses      46024    46170     +146     
  Partials      605      605

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit f2fd6f8 into pola-rs:main Feb 27, 2025
17 of 19 checks passed
anath2 pushed a commit to anath2/polars that referenced this pull request Mar 5, 2025
@Matt711 @anath2
docs(python): Specify that the key column must be sorted in ascending…
148d587 
… order in `merge_sorted` (pola-rs#21501)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

merge_sorted produces incorrect results when merge column is sorted in descending order
2 participants
@Matt711 @ritchie46