Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove Growable in favor of ArrayBuilder #21500

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Feb 27, 2025

This replaces the last usage of the Growable (in the filter and if-then-else for nested types), allowing us to remove it.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 79.08497% with 32 lines in your changes missing coverage. Please review.

Project coverage is 79.84%. Comparing base (823bfc9) to head (398e25a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-arrow/src/array/builder.rs 34.37% 21 Missing ⚠️
crates/polars-arrow/src/array/null.rs 21.42% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21500      +/-   ##
==========================================
+ Coverage   79.73%   79.84%   +0.11%     
==========================================
  Files        1605     1592      -13     
  Lines      230053   229179     -874     
  Branches     2623     2623              
==========================================
- Hits       183424   182987     -437     
+ Misses      46024    45587     -437     
  Partials      605      605              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 471d97e into pola-rs:main Feb 27, 2025
22 checks passed
anath2 pushed a commit to anath2/polars that referenced this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants