Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make the Parquet Sink properly phase aware #21499

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@coastalwhite coastalwhite force-pushed the fix/phasify-parquet-sink branch from 28a941e to 990b80a Compare February 27, 2025 14:30
@coastalwhite coastalwhite changed the title refactor: move phase outcome to separate struct fix: Make the Parquet Sink properly phase aware Feb 27, 2025
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 202 lines in your changes missing coverage. Please review.

Project coverage is 79.70%. Comparing base (5e280d9) to head (990b80a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/io_sinks/mod.rs 0.00% 91 Missing ⚠️
crates/polars-stream/src/nodes/io_sinks/parquet.rs 0.00% 87 Missing ⚠️
crates/polars-stream/src/nodes/mod.rs 0.00% 13 Missing ⚠️
crates/polars-stream/src/nodes/io_sinks/csv.rs 0.00% 4 Missing ⚠️
crates/polars-stream/src/nodes/io_sinks/json.rs 0.00% 4 Missing ⚠️
crates/polars-stream/src/nodes/io_sinks/ipc.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21499      +/-   ##
==========================================
- Coverage   79.98%   79.70%   -0.28%     
==========================================
  Files        1598     1605       +7     
  Lines      229320   230127     +807     
  Branches     2623     2623              
==========================================
+ Hits       183412   183426      +14     
- Misses      45303    46096     +793     
  Partials      605      605              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite merged commit c1e6be9 into pola-rs:main Feb 27, 2025
23 checks passed
@coastalwhite coastalwhite deleted the fix/phasify-parquet-sink branch February 27, 2025 14:56
anath2 pushed a commit to anath2/polars that referenced this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant