perf: Provide a fallback skip batch predicate for constant batches #21477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a fallback for skip batch predicate if we don't have a better specialized implementation. Namely any expression that does not have a better fallback now gets lowered to: ``` E -> all(col(A_min) == col(A_max) & col(A_nc) == 0 for A in LIVE(E)) & ~(E) ``` This basically means that if the predicate columns are constant for a batch, we now are always accurately predict whether we can skip it. Specifically, this makes pruning hive partitions much more consistent and potent. Fixes pola-rs#21472.
coastalwhite
requested review from
ritchie46,
orlp and
c-peters
as code owners
github-actions
bot
added
performance
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21477 +/- ##
==========================================
- Coverage 80.02% 79.99% -0.03%
==========================================
Files 1597 1598 +1
Lines 229111 229265 +154
Branches 2620 2623 +3
==========================================
+ Hits 183338 183402 +64
- Misses 45174 45258 +84
- Partials 599 605 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a fallback for skip batch predicate if we don't have a better specialized implementation. Namely any expression that does not have a better fallback now gets lowered to:
This basically means that if the predicate columns are constant for a batch, we now are always accurately predict whether we can skip it.
Specifically, this makes pruning hive partitions much more consistent and potent.
Fixes #21472.