Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): Mention that statistics=True doesn't enable all statistics in sink_parquet() #21434

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

etiennebacher
Copy link
Contributor

Fixes #21431.

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars labels Feb 24, 2025
@etiennebacher etiennebacher force-pushed the docs-statistics-sink-parquet branch from 1bd7c01 to dc3d63b Compare February 24, 2025 12:43
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.00%. Comparing base (93bfd2c) to head (a9be993).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21434      +/-   ##
==========================================
+ Coverage   79.94%   80.00%   +0.06%     
==========================================
  Files        1597     1597              
  Lines      229007   229024      +17     
  Branches     2620     2620              
==========================================
+ Hits       183074   183226     +152     
+ Misses      45334    45199     -135     
  Partials      599      599              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite
Copy link
Collaborator

This is the same for write_parquet. I think the change should be there too.

@coastalwhite coastalwhite merged commit 4c08d28 into pola-rs:main Feb 24, 2025
15 checks passed
anath2 pushed a commit to anath2/polars that referenced this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

statistics=True sets distinct_count=False in sink_parquet()
2 participants