Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Reduce sharing in stringview arrays in new-streaming equijoin #21129

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Feb 7, 2025

This is a regression on some queries in PDS-H but gets rid of really problematic contention in others, so makes behavior more predictable & scalable.

The PR also includes some unused code for avoiding sharing in a chunked gather. From experimenting that was slower but I left it in because it might come in handy in the future for more experimentation.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Feb 7, 2025
@ritchie46 ritchie46 merged commit 9565c70 into pola-rs:main Feb 7, 2025
20 checks passed
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 52.41935% with 59 lines in your changes missing coverage. Please review.

Project coverage is 79.07%. Comparing base (13186ba) to head (3981c0e).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...tes/polars-ops/src/chunked_array/gather/chunked.rs 69.04% 26 Missing ⚠️
crates/polars-core/src/frame/mod.rs 0.00% 14 Missing ⚠️
crates/polars-stream/src/nodes/joins/equi_join.rs 0.00% 11 Missing ⚠️
crates/polars-arrow/src/array/binview/mod.rs 0.00% 7 Missing ⚠️
crates/polars-expr/src/expressions/window.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21129      +/-   ##
==========================================
- Coverage   79.09%   79.07%   -0.03%     
==========================================
  Files        1592     1592              
  Lines      227174   227243      +69     
  Branches     2594     2594              
==========================================
+ Hits       179692   179693       +1     
- Misses      46886    46954      +68     
  Partials      596      596              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants