Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Fix credential provider error #21092

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Feb 5, 2025

@nameexhaustion nameexhaustion added the skip changelog Do not include in changelog label Feb 5, 2025
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Feb 5, 2025
@nameexhaustion nameexhaustion changed the title fix: Fix credential provider test fix(python): Fix credential provider error Feb 5, 2025
@nameexhaustion nameexhaustion removed the rust Related to Rust Polars label Feb 5, 2025
@nameexhaustion nameexhaustion force-pushed the credential-provider-error branch from 7e67e5e to 6fda111 Compare February 5, 2025 10:52
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.26%. Comparing base (a578d51) to head (973dad0).
Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
py-polars/polars/io/cloud/credential_provider.py 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21092      +/-   ##
==========================================
- Coverage   79.27%   79.26%   -0.01%     
==========================================
  Files        1586     1585       -1     
  Lines      225676   226009     +333     
  Branches     2588     2592       +4     
==========================================
+ Hits       178894   179149     +255     
- Misses      46192    46265      +73     
- Partials      590      595       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion
Copy link
Collaborator Author

🟢

@nameexhaustion nameexhaustion marked this pull request as ready for review February 5, 2025 11:31
@ritchie46 ritchie46 merged commit e17f4b2 into pola-rs:main Feb 5, 2025
17 checks passed
@c-peters c-peters added the accepted Ready for implementation label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars skip changelog Do not include in changelog
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants