Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Expose unity catalog dataclasses and type aliases #21046

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Feb 3, 2025

This exposes the dataclasses and some type aliases (e.g. TableType) to Python (importable from polars.catalog.unity), as well as the reference guide:

image

The existing reference guide entries are also moved to a "Unity Catalog" subsection in the reference guide.

Otherwise, the rest of this diff in this PR would be moving code, mainly splitting py-polars/polars/catalog.py into separate files:

py-polars/polars/catalog/
├── __init__.py
└── unity
    ├── __init__.py
    ├── client.py
    └── models.py

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 14.53155% with 447 lines in your changes missing coverage. Please review.

Project coverage is 79.27%. Comparing base (db712e4) to head (dd275b3).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-python/src/catalog/unity.rs 3.12% 434 Missing ⚠️
py-polars/polars/catalog/unity/models.py 80.59% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21046      +/-   ##
==========================================
- Coverage   79.28%   79.27%   -0.01%     
==========================================
  Files        1583     1585       +2     
  Lines      225549   225557       +8     
  Branches     2586     2586              
==========================================
+ Hits       178816   178817       +1     
- Misses      46143    46150       +7     
  Partials      590      590              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review February 3, 2025 06:04
@nameexhaustion nameexhaustion changed the title feat(python): Expose catalog dataclasses and type aliases feat(python): Expose unity catalog dataclasses and type aliases Feb 3, 2025
@ritchie46 ritchie46 merged commit d23ddc0 into pola-rs:main Feb 3, 2025
32 checks passed
@c-peters c-peters added the accepted Ready for implementation label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants