fix: Invalidate sortedness flag when sorting from pl.Categorical to pl.Categorical("lexical") #21044
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharth-vi
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21044 +/- ##
==========================================
- Coverage 79.34% 79.21% -0.13%
==========================================
Files 1579 1583 +4
Lines 224319 225554 +1235
Branches 2573 2586 +13
==========================================
+ Hits 177976 178670 +694
- Misses 45755 46294 +539
- Partials 588 590 +2 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20864 .
As we never set sorted flags for pl.Categorical("lexical"), when casting to it we need to explicitly set it to not sorted.