Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Split last rowgroup among all threads in new-streaming parquet reader #21027

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jan 31, 2025

This isn't very flexible but at least ensures that for single-rowgroup files we're parallel even if it would be smaller than the ideal row group size, in case it feeds into an expensive operator.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 79.16%. Comparing base (8837dc8) to head (be60857).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...polars-stream/src/nodes/io_sources/parquet/init.rs 0.00% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21027      +/-   ##
==========================================
+ Coverage   79.14%   79.16%   +0.02%     
==========================================
  Files        1583     1583              
  Lines      225119   225248     +129     
  Branches     2581     2586       +5     
==========================================
+ Hits       178162   178324     +162     
+ Misses      46367    46334      -33     
  Partials      590      590              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit c7888de into pola-rs:main Jan 31, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants