Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add make fix for running cargo clippy --fix #21024

Merged
merged 2 commits into from
Jan 31, 2025
Merged

chore: Add make fix for running cargo clippy --fix #21024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3514d18
chore: Add make fix for running cargo fix + clippy --fix
orlp Jan 31, 2025
0fd9c95
clippy --fix seems to cover cargo fix already
orlp Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,13 @@ fmt: ## Run autoformatting and linting
cargo fmt --all
dprint fmt
$(VENV_BIN)/typos

.PHONY: fix
fix:
cargo clippy --workspace --all-targets --all-features --fix
@# Good chance the fixing introduced formatting issues, best to just do a quick format.
cargo fmt --all


.PHONY: pre-commit
pre-commit: fmt clippy clippy-default ## Run all code quality checks
Expand Down
4 changes: 4 additions & 0 deletions crates/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
SHELL=bash
BASE ?= main

.PHONY: fix
fix:
@$(MAKE) -s -C .. $@

.PHONY: fmt
fmt: ## Run rustfmt and dprint
cargo fmt --all
Expand Down
4 changes: 4 additions & 0 deletions py-polars/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ build-debug-release: .venv ## Same as build-release, but with full debug symbol
.PHONY: build-dist-release
build-dist-release: .venv ## Compile and install Python Polars binary with super slow extra optimization turned on, for distribution
@$(MAKE) -s -C .. $@

.PHONY: fix
fix:
@$(MAKE) -s -C .. $@

.PHONY: lint
lint: .venv ## Run lint checks (only)
Expand Down
Loading