Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move dt.replace tests to dedicated file, add "typing :: typed" classifier, remove unused testing function #20945

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

MarcoGorelli
Copy link
Collaborator

@MarcoGorelli MarcoGorelli commented Jan 28, 2025

  • is_sorted_any is defined in py-polars/tests/unit/operations/test_sort.py, but unused anywhere
  • py-polars/tests/unit/operations/namespaces/temporal/test_datetime.py is too large, moving the .dt.replace tests to a separate file
  • Polars already exports excellent type hints, but is missing the "typing :: typed" classifier (https://pypi.org/classifiers/), so it doesn't show up on https://pypi.org/search/?c=Typing+%3A%3A+Typed . Some typing-related projects are looking at that to check type coverage for popular projects, and given how good and useful Polars' types are, I think it'd be good for it to show up

@MarcoGorelli MarcoGorelli force-pushed the add-typing-classifier branch from 20f7a6b to 50433e7 Compare January 28, 2025 09:24
@MarcoGorelli MarcoGorelli changed the title chore: move dt.replace tests to dedicated file, add "typing :: typed" classifier, remove unused testing function chore: Move dt.replace tests to dedicated file, add "typing :: typed" classifier, remove unused testing function Jan 28, 2025
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Jan 28, 2025
@MarcoGorelli MarcoGorelli marked this pull request as ready for review January 28, 2025 09:29
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.30%. Comparing base (6a3fc59) to head (50433e7).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20945      +/-   ##
==========================================
- Coverage   79.30%   79.30%   -0.01%     
==========================================
  Files        1578     1578              
  Lines      224135   224135              
  Branches     2574     2574              
==========================================
- Hits       177751   177746       -5     
- Misses      45793    45798       +5     
  Partials      591      591              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit e5f4d7a into pola-rs:main Jan 28, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants