Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Reduce bloat in static_array_collect by using BitmapBuilders #20891

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jan 24, 2025

In some cases this might be a bit slower but I don't think the heavy unrolling and macro inlining of the previous implementation was justified to use in such a general and often used method.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Jan 24, 2025
@orlp orlp merged commit 22c7879 into pola-rs:main Jan 24, 2025
22 checks passed
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 77.65957% with 21 lines in your changes missing coverage. Please review.

Project coverage is 79.73%. Comparing base (7ccb3ae) to head (c355a82).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
...tes/polars-arrow/src/array/static_array_collect.rs 77.65% 21 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20891   +/-   ##
=======================================
  Coverage   79.73%   79.73%           
=======================================
  Files        1566     1566           
  Lines      222591   222678   +87     
  Branches     2572     2572           
=======================================
+ Hits       177473   177554   +81     
- Misses      44526    44532    +6     
  Partials      592      592           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-peters c-peters added the accepted Ready for implementation label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants