Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Remove last instances of itoa #20881

Merged
merged 5 commits into from
Jan 24, 2025
Merged

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jan 24, 2025

Another dependency down.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.73%. Comparing base (7ccb3ae) to head (58a2fd5).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-arrow/src/compute/decimal.rs 97.77% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20881   +/-   ##
=======================================
  Coverage   79.73%   79.73%           
=======================================
  Files        1566     1566           
  Lines      222591   222604   +13     
  Branches     2572     2572           
=======================================
+ Hits       177473   177485   +12     
- Misses      44526    44527    +1     
  Partials      592      592           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit e98e09b into pola-rs:main Jan 24, 2025
21 checks passed
@c-peters c-peters added the accepted Ready for implementation label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants