Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Simplify decimal formatting and remove itoap dep #20880

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jan 23, 2025

Possibly a bit slower but I doubt it's much different or it forming a bottleneck. Can always optimize it more later.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.72%. Comparing base (b64b764) to head (1499965).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-compute/src/cast/decimal_to.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20880      +/-   ##
==========================================
- Coverage   79.73%   79.72%   -0.01%     
==========================================
  Files        1566     1566              
  Lines      222574   222559      -15     
  Branches     2562     2562              
==========================================
- Hits       177460   177445      -15     
  Misses      44525    44525              
  Partials      589      589              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 1de732d into pola-rs:main Jan 24, 2025
22 checks passed
@c-peters c-peters added the accepted Ready for implementation label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants