Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Use BitmapBuilder in yet more places #20868

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jan 23, 2025

This should be the last places where it's appropriate to replace MutableBitmap, except for those in polars-parquet but that will undergo a separate refactor.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.64%. Comparing base (79eedcf) to head (6393728).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
...olars-plan/src/dsl/function_expr/shift_and_fill.rs 50.00% 2 Missing ⚠️
...m/src/nodes/io_sources/parquet/row_group_decode.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20868   +/-   ##
=======================================
  Coverage   79.64%   79.64%           
=======================================
  Files        1571     1571           
  Lines      223186   223193    +7     
  Branches     2554     2554           
=======================================
+ Hits       177751   177766   +15     
+ Misses      44850    44842    -8     
  Partials      585      585           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit ca21bd7 into pola-rs:main Jan 23, 2025
23 checks passed
@c-peters c-peters added the accepted Ready for implementation label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants