Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Use downcast_ref instead of dtype equality in <dyn SeriesTrait as AsRef<ChunkedArray<T>> #20664

Merged
merged 4 commits into from
Jan 10, 2025
Merged

perf: Use downcast_ref instead of dtype equality in <dyn SeriesTrait as AsRef<ChunkedArray<T>> #20664

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
194972a
perf: Use downcast_ref instead of dtype equality in SeriesTrait AsRef
coastalwhite Jan 10, 2025
1d59945
fix doc ref
coastalwhite Jan 10, 2025
72d7d89
facepalm
coastalwhite Jan 10, 2025
d681241
doc ref again
coastalwhite Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
doc ref again
  • Loading branch information
@coastalwhite
coastalwhite committed Jan 10, 2025
commit d681241bf1fc9d10afdf5b57c31b7c63391efd11
7 changes: 3 additions & 4 deletions crates/polars-core/src/series/series_trait.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,12 +563,11 @@ pub trait SeriesTrait:
invalid_operation_panic!(get_object_chunked_unchecked, self)
}

/// Get a hold of the [`ChunkedArray`], [`Logical`] or
/// [`NullChunked`][super::implementations::null::NullChunked] as an `Any` trait reference.
/// Get a hold of the [`ChunkedArray`], [`Logical`] or `NullChunked` as an `Any` trait
/// reference.
fn as_any(&self) -> &dyn Any;

/// Get a hold of the [`ChunkedArray`], [`Logical`] or
/// [`NullChunked`][super::implementations::null::NullChunked] as an `Any` trait mutable
/// Get a hold of the [`ChunkedArray`], [`Logical`] or `NullChunked` as an `Any` trait mutable
/// reference.
fn as_any_mut(&mut self) -> &mut dyn Any;

Expand Down
Loading