Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Make Parquet verify_dict_indices SIMD #20623

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

coastalwhite
Copy link
Collaborator

This is a few procent faster in a micro-benchmark.

This is a few procent faster in a micro-benchmark.
@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.04%. Comparing base (92fd75d) to head (d3d830e).
Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
...c/arrow/read/deserialize/dictionary_encoded/mod.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20623      +/-   ##
==========================================
+ Coverage   79.00%   79.04%   +0.04%     
==========================================
  Files        1566     1557       -9     
  Lines      221034   220528     -506     
  Branches     2510     2510              
==========================================
- Hits       174618   174310     -308     
+ Misses      45842    45644     -198     
  Partials      574      574              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 247f0b1 into pola-rs:main Jan 8, 2025
23 checks passed
@coastalwhite coastalwhite deleted the perf/pq-verify-indices-simd branch January 8, 2025 14:27
@c-peters c-peters added the accepted Ready for implementation label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants