Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rust): Rename is_numeric to is_primitive_numeric #20574

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jan 6, 2025

It has lead to confusion in the past that Decimal is excluded from the is_numeric dtype method.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Jan 6, 2025
@orlp orlp force-pushed the is-primitive-numeric branch from 528d79d to b4ff1c5 Compare January 6, 2025 14:15
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 94.33962% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.97%. Comparing base (04004b8) to head (e742541).
Report is 52 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-expr/src/reduce/mean.rs 0.00% 2 Missing ⚠️
...-core/src/chunked_array/builder/fixed_size_list.rs 0.00% 1 Missing ⚠️
...rates/polars-core/src/chunked_array/ops/reverse.rs 0.00% 1 Missing ⚠️
crates/polars-core/src/datatypes/any_value.rs 87.50% 1 Missing ⚠️
...tes/polars-core/src/series/implementations/list.rs 66.66% 1 Missing ⚠️
crates/polars-expr/src/reduce/var_std.rs 0.00% 1 Missing ⚠️
crates/polars-ops/src/series/ops/round.rs 75.00% 1 Missing ⚠️
...s-plan/src/plans/conversion/type_coercion/is_in.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20574      +/-   ##
==========================================
- Coverage   78.97%   78.97%   -0.01%     
==========================================
  Files        1564     1564              
  Lines      220807   220826      +19     
  Branches     2510     2510              
==========================================
+ Hits       174377   174390      +13     
- Misses      45855    45861       +6     
  Partials      575      575              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orlp orlp force-pushed the is-primitive-numeric branch from 667f065 to e742541 Compare January 7, 2025 11:03
@ritchie46 ritchie46 merged commit a230ec2 into pola-rs:main Jan 7, 2025
26 checks passed
@c-peters c-peters added the accepted Ready for implementation label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants