Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Don't include debug symbols in benchmark run #20571

Merged
merged 5 commits into from
Jan 10, 2025
Merged

ci: Don't include debug symbols in benchmark run #20571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b6c19e7
ci: Don't include debug symbols in benchmark run
ritchie46 Jan 6, 2025
6bc50ad
and build wheel
ritchie46 Jan 10, 2025
893e31a
use profile: nodebug-release
ritchie46 Jan 10, 2025
f4980b0
typo
ritchie46 Jan 10, 2025
673b6bd
mark debug
ritchie46 Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,15 +67,16 @@ jobs:
- name: Run sccache-cache
uses: mozilla-actions/[email protected]

- name: Install Polars release build
env:
RUSTFLAGS: -C embed-bitcode -D warnings
- name: Build Polars release build
working-directory: py-polars
run: maturin develop --release -- -C codegen-units=8 -C lto=thin -C target-cpu=native
run: maturin build --profile nodebug-release -- -C codegen-units=8 -C lto=thin -C target-cpu=native

- name: Install Polars release build
run: pip install target/wheels/polars*.whl

- name: Set lib size
- name: Set wheel size
run: |
LIB_SIZE=$(ls -l py-polars/polars/polars*.so | awk '{ print $5 }')
LIB_SIZE=$(ls -l target/wheels/polars*.whl | awk '{ print $5 }')
echo "LIB_SIZE=$LIB_SIZE" >> $GITHUB_ENV

- name: Comment wheel size
Expand Down
1 change: 1 addition & 0 deletions py-polars/tests/unit/test_polars_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ def _import_timings_as_frame(n_tries: int) -> tuple[pl.DataFrame, int]:


@pytest.mark.skipif(sys.platform == "win32", reason="Unreliable on Windows")
@pytest.mark.debug
@pytest.mark.slow
def test_polars_import() -> None:
# up-front compile '.py' -> '.pyc' before timing
Expand Down
Loading