Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): Restore symbols on Apple by bumping nightly version #20563

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jan 5, 2025

Function symbols were being stripped from release builds on Apple due to a bug in the Rust compiler, this was fixed recently in rust-lang/rust#135034.

Having symbols in the final shipped binary does make it slightly larger, but makes diagnosing performance issues/bugs on released Polars versions significantly easier. Note that this is only the function names for non-inlined functions, it does not keep all the other debug information.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jan 5, 2025
@orlp orlp changed the title fix: Restore symbols on Apple by bumping nightly version fix(rust): Restore symbols on Apple by bumping nightly version Jan 5, 2025
@ritchie46
Copy link
Member

ritchie46 commented Jan 6, 2025

You need to run clippy and fix the new lints.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

The uncompressed lib size after this PR is 1116.9641 MB.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.98%. Comparing base (e360e0a) to head (8b16d5a).
Report is 62 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-python/src/map/dataframe.rs 0.00% 3 Missing ⚠️
crates/polars-expr/src/expressions/column.rs 50.00% 1 Missing ⚠️
crates/polars-plan/src/dsl/mod.rs 0.00% 1 Missing ⚠️
...ates/polars-stream/src/physical_plan/lower_expr.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20563      +/-   ##
==========================================
- Coverage   78.98%   78.98%   -0.01%     
==========================================
  Files        1564     1564              
  Lines      220759   220738      -21     
  Branches     2504     2504              
==========================================
- Hits       174363   174341      -22     
- Misses      45822    45823       +1     
  Partials      574      574              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit e0ef7f9 into main Jan 6, 2025
21 checks passed
@ritchie46 ritchie46 deleted the toolchain-bump branch January 6, 2025 10:45
@c-peters c-peters added the accepted Ready for implementation label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants