Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use the same encoding for nullable as non-nullable arrays #20323

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

coastalwhite
Copy link
Collaborator

This slipped through during a refactor. I now added some tests that would catch this.

Fixes #20320.

This slipped through during a refactor. I now added some tests that would catch this.

Fixes pola-rs#20320.
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.63%. Comparing base (2fc26cf) to head (dfe0d46).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20323      +/-   ##
==========================================
+ Coverage   79.60%   79.63%   +0.02%     
==========================================
  Files        1567     1567              
  Lines      218528   218527       -1     
  Branches     2462     2462              
==========================================
+ Hits       173969   174029      +60     
+ Misses      43992    43931      -61     
  Partials      567      567              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itamarst
Copy link
Contributor

Thank you!

@ritchie46 ritchie46 merged commit 2f6c23b into pola-rs:main Dec 17, 2024
26 checks passed
@coastalwhite coastalwhite deleted the fix/enum-row-encoding branch December 17, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
3 participants