Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't use RLE encoding for Parquet Boolean #20172

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

coastalwhite
Copy link
Collaborator

This is not really ready yet unless we have compatibility profiles.

Fixes #18819.

This is not really ready yet unless we have compatibility profiles.

Fixes pola-rs#18819.
@coastalwhite coastalwhite changed the title revert: Don't use RLE encoding for Parquet Boolean fix: Don't use RLE encoding for Parquet Boolean Dec 5, 2024
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Dec 5, 2024
@ritchie46 ritchie46 merged commit a1bfeef into pola-rs:main Dec 6, 2024
18 checks passed
@coastalwhite coastalwhite deleted the revert/pq-bool-rle branch December 6, 2024 08:54
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 94.28571% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.60%. Comparing base (cbc0ea0) to head (6679542).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...lars-parquet/src/arrow/read/deserialize/boolean.rs 93.54% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20172      +/-   ##
==========================================
+ Coverage   79.58%   79.60%   +0.02%     
==========================================
  Files        1564     1564              
  Lines      217475   217492      +17     
  Branches     2472     2474       +2     
==========================================
+ Hits       173070   173134      +64     
+ Misses      43837    43789      -48     
- Partials      568      569       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

write_parquet encoding no longer recognized by PBI Service parquet connector after Polars 1.5.0 onwards
2 participants