Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deal with masked out list elements #20161

Merged

Conversation

coastalwhite
Copy link
Collaborator

Fixes #20151.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 98.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.59%. Comparing base (bcfa7ec) to head (6cf9369).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-row/src/encode.rs 98.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20161      +/-   ##
==========================================
+ Coverage   79.57%   79.59%   +0.02%     
==========================================
  Files        1563     1564       +1     
  Lines      217395   217551     +156     
  Branches     2472     2472              
==========================================
+ Hits       172986   173157     +171     
+ Misses      43841    43826      -15     
  Partials      568      568              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit b019e42 into pola-rs:main Dec 5, 2024
26 checks passed
@coastalwhite coastalwhite deleted the fix/row-encoding-masked-out-lists-20151 branch December 5, 2024 09:45
@itamarst
Copy link
Contributor

itamarst commented Dec 5, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in row encoding: bad output in same cases for lists
3 participants