expose connectorx 'protocol' param to "read_sql" so it can work with redshift #2003
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to (but not dependent on) sfu-db/connector-x/#187. This is a small patch that adds the 'protocol' param to polars'
read_sql
so that it can be passed-through to connectorx; this is required for redshift backends as the param has to be set to a non-default value ('cursor' instead of 'binary'), otherwise loading fails. No change to default behaviour or other parameters.BEFORE
AFTER
Also added some additional test coverage for
read_sql
, and made some trivial docstring updates (in line with the connectorx patch referenced above). Thanks!