fix: Fix incorrect result from inequality filter after join on LazyFrame #19898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
nameexhaustion
force-pushed
the
join-filter-pushdown
branch
from
05d687f to
37b57a4
Compare
nameexhaustion
commented
Nov 21, 2024
| @@ -45,8 +45,7 @@ fn should_block_join_specific( | |||
| // the join can produce null values | |||
| // TODO! check if we can be less conservative here | |||
| BinaryExpr { op, left, right } => match op { | |||
| Operator::NotEq => LeftRight(false, false), | |||
There was a problem hiding this comment.
inequality had its own branch - I'm not sure why but I've removed it
nameexhaustion
commented
Nov 21, 2024
| @@ -62,7 +61,7 @@ fn should_block_join_specific( | |||
| }, | |||
| _ => join_produces_null(how), | |||
| }, | |||
| _ => LeftRight(false, false), | |||
| _ => join_produces_null(how), | |||
There was a problem hiding this comment.
for catch-all we need to at least follow the join_produces_null rule
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19898 +/- ##
==========================================
- Coverage 79.43% 79.43% -0.01%
==========================================
Files 1554 1554
Lines 215611 215611
Branches 2452 2452
==========================================
- Hits 171278 171277 -1
- Misses 43775 43776 +1
Partials 558 558 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
nameexhaustion
force-pushed
the
join-filter-pushdown
branch
from
2b6d34e to
5ee8f61
Compare
ritchie46
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19772