Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Type hints for window_size incorrectly included timedelta in some rolling functions #19827

Merged
merged 1 commit into from
Nov 17, 2024
Merged

fix: Type hints for window_size incorrectly included timedelta in some rolling functions #19827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions py-polars/polars/expr/expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7657,7 +7657,7 @@ def rolling_mean(
@unstable()
def rolling_sum(
self,
window_size: int | timedelta,
window_size: int,
weights: list[float] | None = None,
*,
min_periods: int | None = None,
Expand Down Expand Up @@ -7768,7 +7768,7 @@ def rolling_sum(
@unstable()
def rolling_std(
self,
window_size: int | timedelta,
window_size: int,
weights: list[float] | None = None,
*,
min_periods: int | None = None,
Expand Down Expand Up @@ -7883,7 +7883,7 @@ def rolling_std(
@unstable()
def rolling_var(
self,
window_size: int | timedelta,
window_size: int,
weights: list[float] | None = None,
*,
min_periods: int | None = None,
Expand Down Expand Up @@ -7998,7 +7998,7 @@ def rolling_var(
@unstable()
def rolling_median(
self,
window_size: int | timedelta,
window_size: int,
weights: list[float] | None = None,
*,
min_periods: int | None = None,
Expand Down Expand Up @@ -8111,7 +8111,7 @@ def rolling_quantile(
self,
quantile: float,
interpolation: RollingInterpolationMethod = "nearest",
window_size: int | timedelta = 2,
window_size: int = 2,
weights: list[float] | None = None,
*,
min_periods: int | None = None,
Expand Down
Loading