-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Cast empty lists and lists of only nulls without an inner dtype #15525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrosbar
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
April 7, 2024 10:13
github-actions
bot
added
fix
Bug fix
python
Related to Python Polars
rust
Related to Rust Polars
labels
Apr 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15525 +/- ##
=======================================
Coverage 80.39% 80.40%
=======================================
Files 1264 1264
Lines 165421 165434 +13
=======================================
+ Hits 132994 133019 +25
+ Misses 32427 32415 -12 ☔ View full report in Codecov by Sentry. |
ritchie46
requested changes
Apr 8, 2024
petrosbar
force-pushed
the
anyvalue-empty-list
branch
from
April 11, 2024 19:19
4717231
to
1c0ecd2
Compare
CodSpeed Performance ReportMerging #15525 will improve performances by 16.33%Comparing Summary
Benchmarks breakdown
|
ritchie46
reviewed
Apr 12, 2024
petrosbar
changed the title
fix: Cast empty lists in Series of lists without an inner dtype
fix: Cast empty lists and lists of only nulls without an inner dtype
Apr 12, 2024
ritchie46
reviewed
Apr 13, 2024
petrosbar
force-pushed
the
anyvalue-empty-list
branch
from
April 19, 2024 18:53
84caced
to
01064c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15523
When building a Series of lists without specifying an inner dtype, if there's any empty list, construction will panic. The reason is that in
AnyValue::List(b)
, ifb
is empty, its dtype isNull
regardless of the dtype of the other lists.