Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "fixed" employee status #197

Merged
merged 1 commit into from
Jan 16, 2021
Merged

Added "fixed" employee status #197

merged 1 commit into from
Jan 16, 2021

Conversation

gbenziv
Copy link
Contributor

@gbenziv gbenziv commented Jan 16, 2021

xxxx

  • Status should be ACTIVE, ON-LEAVE or INACTIVE

Pull Request Checklist

  • I have ensured that my commit message contains the Issue ID.
  • I have ensured that my commit message contains the feature/bugfix description.
  • I have updated the documentation accordingly.
  • I have ensured my code follows the coding guidelines.
  • I have ran lint in my code locally prior to submission.
  • I have built my changes in local successfully.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

xxxx

- Status should be ACTIVE, ON-LEAVE or INACTIVE
@codecov
Copy link

codecov bot commented Jan 16, 2021

Codecov Report

Merging #197 (df39ca8) into master (ed97599) will increase coverage by 0.12%.
The diff coverage is 95.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   95.33%   95.45%   +0.12%     
==========================================
  Files          45       46       +1     
  Lines         900     1034     +134     
==========================================
+ Hits          858      987     +129     
- Misses         42       47       +5     
Impacted Files Coverage Δ
core/domain/common/basecontroller.hpp 100.00% <ø> (ø)
core/domain/common/cachecontroller.hpp 100.00% <ø> (ø)
core/domain/inventory/inventorycontroller.hpp 100.00% <ø> (ø)
core/entity/employee.hpp 100.00% <ø> (ø)
core/validator/productvalidator.hpp 100.00% <ø> (ø)
core/domain/unittest/test_inventory.cpp 96.66% <93.18%> (-3.34%) ⬇️
core/domain/inventory/inventorycontroller.cpp 97.82% <100.00%> (+2.91%) ⬆️
...main/unittest/mock/inventory/inventorydatamock.hpp 100.00% <100.00%> (ø)
core/entity/uom.hpp 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db2295...df39ca8. Read the comment docs.

@gbenziv gbenziv merged commit 16e0880 into master Jan 16, 2021
@gbenziv gbenziv deleted the dev/EmployeeStatus branch January 16, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant