Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for unit of measurement #195

Merged
merged 4 commits into from
Jan 16, 2021
Merged

Added support for unit of measurement #195

merged 4 commits into from
Jan 16, 2021

Conversation

gbenziv
Copy link
Contributor

@gbenziv gbenziv commented Jan 15, 2021

Closes #194

  • Created UOM entity
  • Updated API comments
  • Added UOM to stack DB
  • Added validator and display
  • Added unit tests

Pull Request Checklist

  • I have ensured that my commit message contains the Issue ID.
  • I have ensured that my commit message contains the feature/bugfix description.
  • I have updated the documentation accordingly.
  • I have ensured my code follows the coding guidelines.
  • I have ran lint in my code locally prior to submission.
  • I have built my changes in local successfully.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Closes #194

- Created UOM entity
- Updated API comments
- Added UOM to stack DB
@gbenziv gbenziv added the WIP Work in Progress label Jan 15, 2021
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #195 (1c1f69a) into master (ed97599) will increase coverage by 0.12%.
The diff coverage is 95.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   95.33%   95.45%   +0.12%     
==========================================
  Files          45       46       +1     
  Lines         900     1034     +134     
==========================================
+ Hits          858      987     +129     
- Misses         42       47       +5     
Impacted Files Coverage Δ
core/domain/common/basecontroller.hpp 100.00% <ø> (ø)
core/domain/common/cachecontroller.hpp 100.00% <ø> (ø)
core/domain/inventory/inventorycontroller.hpp 100.00% <ø> (ø)
core/validator/productvalidator.hpp 100.00% <ø> (ø)
core/domain/unittest/test_inventory.cpp 96.66% <93.18%> (-3.34%) ⬇️
core/domain/inventory/inventorycontroller.cpp 97.82% <100.00%> (+2.91%) ⬆️
...main/unittest/mock/inventory/inventorydatamock.hpp 100.00% <100.00%> (ø)
core/entity/uom.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed97599...611c37b. Read the comment docs.

@gbenziv gbenziv removed the WIP Work in Progress label Jan 16, 2021
@gbenziv gbenziv merged commit 2db2295 into master Jan 16, 2021
@gbenziv gbenziv deleted the dev/194 branch January 16, 2021 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Product Entity
1 participant