Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Core controller baseclass #191

Merged
merged 4 commits into from
Jan 13, 2021
Merged

Created Core controller baseclass #191

merged 4 commits into from
Jan 13, 2021

Conversation

gbenziv
Copy link
Contributor

@gbenziv gbenziv commented Jan 12, 2021

Closes #177

  • Moved dumpValidationResult
  • Removed dataprovider and view members
  • Created cachelist controller
  • Updated CMake and typedefs

Pull Request Checklist

  • I have ensured that my commit message contains the Issue ID.
  • I have ensured that my commit message contains the feature/bugfix description.
  • I have updated the documentation accordingly.
  • I have ensured my code follows the coding guidelines.
  • I have ran lint in my code locally prior to submission.
  • I have built my changes in local successfully.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Closes #177

- Moved dumpValidationResult
@gbenziv gbenziv added the WIP Work in Progress label Jan 12, 2021
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #191 (ae979d7) into master (30d3a67) will increase coverage by 4.55%.
The diff coverage is 97.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   90.78%   95.33%   +4.55%     
==========================================
  Files          43       45       +2     
  Lines         792      900     +108     
==========================================
+ Hits          719      858     +139     
+ Misses         73       42      -31     
Impacted Files Coverage Δ
...ore/domain/customermgmt/customermgmtcontroller.hpp 100.00% <ø> (ø)
core/domain/dashboard/dashboardcontroller.hpp 100.00% <ø> (ø)
core/domain/employeemgmt/employeecontroller.hpp 100.00% <ø> (ø)
core/domain/inventory/inventorycontroller.hpp 100.00% <ø> (ø)
core/domain/dashboard/dashboardcontroller.cpp 89.65% <66.66%> (ø)
core/domain/userlogin/logincontroller.cpp 92.85% <66.66%> (ø)
core/domain/inventory/inventorycontroller.cpp 94.91% <93.33%> (-0.80%) ⬇️
core/domain/employeemgmt/employeecontroller.cpp 96.07% <94.11%> (-0.29%) ⬇️
core/domain/common/basecontroller.hpp 100.00% <100.00%> (ø)
core/domain/common/cachecontroller.hpp 100.00% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fa3f7b...d1db21d. Read the comment docs.

@gbenziv gbenziv added Ready for review Needs review and removed WIP Work in Progress labels Jan 13, 2021
@gbenziv gbenziv merged commit 40a0df2 into master Jan 13, 2021
@gbenziv gbenziv deleted the dev/177 branch January 13, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for review Needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Core controller base class
1 participant