Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented get customer details feature #185

Merged
merged 1 commit into from
Jan 9, 2021
Merged

Implemented get customer details feature #185

merged 1 commit into from
Jan 9, 2021

Conversation

gbenziv
Copy link
Contributor

@gbenziv gbenziv commented Jan 7, 2021

Closes #160

  • Created screen
  • Added implementation in Core API
  • Added unit tests

Pull Request Checklist

  • I have ensured that my commit message contains the Issue ID.
  • I have ensured that my commit message contains the feature/bugfix description.
  • I have updated the documentation accordingly.
  • I have ensured my code follows the coding guidelines.
  • I have ran lint in my code locally prior to submission.
  • I have built my changes in local successfully.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Closes #160

- Created screen
- Added implementation in Core API
- Added unit tests
@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #185 (fbf4b99) into master (2699ef1) will increase coverage by 1.80%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   89.61%   91.42%   +1.80%     
==========================================
  Files          43       43              
  Lines         780      816      +36     
==========================================
+ Hits          699      746      +47     
+ Misses         81       70      -11     
Impacted Files Coverage Δ
...ore/domain/customermgmt/customermgmtcontroller.hpp 100.00% <ø> (ø)
...ore/domain/customermgmt/customermgmtcontroller.cpp 44.68% <100.00%> (+36.10%) ⬆️
core/domain/unittest/test_customermgmt.cpp 100.00% <100.00%> (ø)
core/domain/unittest/test_inventory.cpp 100.00% <100.00%> (ø)
...nittest/mock/customermgmt/customermgmtdatamock.hpp 50.00% <0.00%> (+16.66%) ⬆️
...nittest/mock/customermgmt/customermgmtviewmock.hpp 60.00% <0.00%> (+20.00%) ⬆️
core/entity/customer.hpp 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30d3a67...fbf4b99. Read the comment docs.

@gbenziv gbenziv merged commit 140b12d into master Jan 9, 2021
@gbenziv gbenziv deleted the dev/160 branch January 9, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for review Needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement get customer feature
1 participant