Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VER] Bump up Swift compiler version to 5.7.1 to follow Apple's policy #140

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

x-0o0
Copy link
Contributor

@x-0o0 x-0o0 commented Nov 19, 2023

Since April, the apps and SDKs must be built in Xcode 14.1 + to submit to the AppStore. To support Xcode 14.1+, I modified the swift version to 5.7.1 from 5.7

Reference: developer.apple.com/news

swift-composable-architecture| #PR 2549 has already applied the same updates

After this changes, it no longer needs to worry about the apple-side bug that caused some public-facing API to specify support for versions 5.7.1+ : swiftlang/swift#60550


In addition, since April 2024, the apps and SDKs must be built in Xcode 15+ to submit to the AppStore. Therefore, versions under 5.9 will no longer be needed to be supported after that date

Reference: developer.apple.com/ios/submit

@x-0o0
Copy link
Contributor Author

x-0o0 commented Nov 26, 2023

@stephencelis Hi, Could you check this PR please?

Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephencelis
Copy link
Member

@x-0o0 Unfortunately it looks like SwiftWasm is confused by the 5.7.1 tools version even though our CI is running against 5.7.1 😕 Not sure if this is a bug in Wasm, or in our CI.

@x-0o0
Copy link
Contributor Author

x-0o0 commented Dec 1, 2023

I found this issue from Carton repository of SwiftWasm: swiftwasm/carton#399

Could this be related to this issue?

@stephencelis
Copy link
Member

@x-0o0 Possibly! Wanna try bumping this down to an earlier version of Ubuntu?

https://github.com/pointfreeco/swift-dependencies/blob/main/.github/workflows/ci.yml#L57

@x-0o0 x-0o0 force-pushed the jaesung-0o0/swift-version-5.7.1 branch 2 times, most recently from 79afe58 to d28e4fa Compare December 7, 2023 13:30
@x-0o0
Copy link
Contributor Author

x-0o0 commented Dec 7, 2023

@stephencelis Hi, sorry for the late update.

I downgraded ubuntu version to 20.04 while referring to actions runner images: https://github.com/actions/runner-images#available-images

However, it kept failing.

Based on the following error, IMO, [email protected] installs some package version 5.7.0 that cannot be compiled on Swift 5.7.1
Error: : package 'workspace' is using Swift tools version 5.7.1 but the installed version is 5.7.0

Therefore, I upgraded swiftwasm-action version from 5.7 to 5.8

- uses: swiftwasm/[email protected]

and after the update, it fetched the executable and package for 5.7.1 well. Here is some part of the current logs where it showed error previous commit:

- swift executable: /root/.carton/sdk/wasm-5.7.1-RELEASE/usr/bin/swift
SwiftWasm Swift version 5.7.1 (swiftlang-5.7.1)
Target: x86_64-unknown-linux-gnu

Parsing package manifest: 
[debug]: evaluating manifest for 'workspace' v. unknown- test bundle to run: /github/workspace/.build/wasm32-unknown-wasi/debug/swift-dependenciesPackageTests.wasm

Building the test bundle before running the test suite...

@x-0o0 x-0o0 force-pushed the jaesung-0o0/swift-version-5.7.1 branch from d28e4fa to 02d1329 Compare December 8, 2023 16:05
@x-0o0
Copy link
Contributor Author

x-0o0 commented Dec 8, 2023

@stephencelis
Copy link
Member

Thanks again!

@stephencelis stephencelis merged commit 5901e46 into pointfreeco:main Dec 11, 2023
8 checks passed
@x-0o0 x-0o0 deleted the jaesung-0o0/swift-version-5.7.1 branch December 14, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants