-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VER] Bump up Swift compiler version to 5.7.1 to follow Apple's policy #140
[VER] Bump up Swift compiler version to 5.7.1 to follow Apple's policy #140
Conversation
@stephencelis Hi, Could you check this PR please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@x-0o0 Unfortunately it looks like SwiftWasm is confused by the 5.7.1 tools version even though our CI is running against 5.7.1 😕 Not sure if this is a bug in Wasm, or in our CI. |
I found this issue from Carton repository of SwiftWasm: swiftwasm/carton#399 Could this be related to this issue? |
@x-0o0 Possibly! Wanna try bumping this down to an earlier version of Ubuntu? https://github.com/pointfreeco/swift-dependencies/blob/main/.github/workflows/ci.yml#L57 |
79afe58
to
d28e4fa
Compare
@stephencelis Hi, sorry for the late update. I downgraded ubuntu version to 20.04 while referring to actions runner images: https://github.com/actions/runner-images#available-images However, it kept failing. Based on the following error, IMO, Therefore, I upgraded swiftwasm-action version from 5.7 to 5.8 - uses: swiftwasm/[email protected] and after the update, it fetched the executable and package for 5.7.1 well. Here is some part of the current logs where it showed error previous commit:
|
d28e4fa
to
02d1329
Compare
@stephencelis Could you run this workflow? https://github.com/pointfreeco/swift-dependencies/actions/runs/7143553554 |
Thanks again! |
Since April, the apps and SDKs must be built in Xcode 14.1 + to submit to the AppStore. To support Xcode 14.1+, I modified the swift version to 5.7.1 from 5.7
swift-composable-architecture| #PR 2549 has already applied the same updates
After this changes, it no longer needs to worry about the apple-side bug that caused some public-facing API to specify support for versions 5.7.1+ : swiftlang/swift#60550
In addition, since April 2024, the apps and SDKs must be built in Xcode 15+ to submit to the AppStore. Therefore, versions under 5.9 will no longer be needed to be supported after that date