Skip to content
This repository has been archived by the owner on May 24, 2021. It is now read-only.

Commit

Permalink
style(chapters): change link_title name to linkTitle and fix whitespace
Browse files Browse the repository at this point in the history
  • Loading branch information
monkeydom committed Sep 6, 2018
1 parent bcf2534 commit 46626c7
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 13 deletions.
6 changes: 3 additions & 3 deletions src/components/tabs/chapters/ChapterEntry.vue
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
@click.alt="onChapterClick"
aria-hidden="true">
<span class="title truncate" aria-hidden="true">{{chapter.title}}</span>
<span class="link" v-if="chapter.href"><link-icon class="icon"></link-icon><a class="info-link truncate" :href="chapter.href" target="_blank" @mouseover="onMouseOverLink" @mouseleave="onMouseLeaveLink">{{chapter.link_title}}</a></span>
<span class="link" v-if="chapter.href"><link-icon class="icon"></link-icon><a class="info-link truncate" :href="chapter.href" target="_blank" @mouseover="onMouseOverLink" @mouseleave="onMouseLeaveLink">{{chapter.linkTitle}}</a></span>
<span class="timer" aria-hidden="true">{{remainingTime}}</span>
<span class="progress" :style="progressStyle" aria-hidden="true"></span>
<span class="progress" :style="progressGhostStyle"></span>
Expand Down Expand Up @@ -221,8 +221,8 @@
}
.info-link {
font-weight: 700;
text-align:right;
font-weight: bolder;
text-align: right;
}
.link {
Expand Down
2 changes: 1 addition & 1 deletion src/effects/chapters.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const parseChapters = duration => (result, chapter, index, chapters) => {
title: get(chapter, 'title'),
image: get(chapter, 'image'),
href: get(chapter, 'href') ? get(chapter, 'href') : null,
link_title: get(chapter, 'href') ? new URL(get(chapter, 'href')).hostname.replace(/^(www\.)/, '') : null
linkTitle: get(chapter, 'href') ? new URL(get(chapter, 'href')).hostname.replace(/^(www\.)/, '') : null
}
]
}
Expand Down
18 changes: 9 additions & 9 deletions src/effects/chapters.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ test.cb(
index: 1,
image: 'dummy',
href: null,
link_title: null
linkTitle: null
},
{
active: true,
Expand All @@ -107,7 +107,7 @@ test.cb(
index: 2,
image: undefined,
href: null,
link_title: null
linkTitle: null
},
{
active: false,
Expand All @@ -117,7 +117,7 @@ test.cb(
index: 3,
image: 'dummy',
href: 'https://github.com/podlove/podlove-web-player/blob/development/CONTRIBUTING.md#-git-commit-guidelines',
link_title: 'github.com'
linkTitle: 'github.com'
}
])
t.end()
Expand Down Expand Up @@ -165,7 +165,7 @@ test.cb(
index: 1,
image: 'dummy',
href: null,
link_title: null
linkTitle: null
},
{
active: true,
Expand All @@ -175,7 +175,7 @@ test.cb(
index: 2,
image: undefined,
href: null,
link_title: null
linkTitle: null
},
{
active: false,
Expand All @@ -185,7 +185,7 @@ test.cb(
index: 3,
image: 'dummy',
href: null,
link_title: null
linkTitle: null
}
])
t.end()
Expand Down Expand Up @@ -235,7 +235,7 @@ test.cb(
index: 1,
image: 'dummy',
href: null,
link_title: null
linkTitle: null
},
{
active: true,
Expand All @@ -245,7 +245,7 @@ test.cb(
index: 2,
image: undefined,
href: null,
link_title: null
linkTitle: null
},
{
active: false,
Expand All @@ -255,7 +255,7 @@ test.cb(
index: 3,
image: 'dummy',
href: null,
link_title: null
linkTitle: null
}
])
t.end()
Expand Down

0 comments on commit 46626c7

Please sign in to comment.