Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmake): remove libatomic dependency #4811

Merged
merged 1 commit into from
Dec 7, 2024
Merged

fix(cmake): remove libatomic dependency #4811

merged 1 commit into from
Dec 7, 2024

Conversation

aleks-f
Copy link
Member

@aleks-f aleks-f commented Dec 3, 2024

No description provided.

@aleks-f aleks-f added this to the Release 1.14.1 milestone Dec 3, 2024
@aleks-f aleks-f mentioned this pull request Dec 3, 2024
Closed
@aleks-f aleks-f requested a review from matejk December 3, 2024 23:26
matejk
matejk requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@matejk matejk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linking libatomic came in with a patch that Debian applies in their build system.

I think that it is only required on 32-bit platforms and not 64-bit. Most probably linking can be made private as well for libatomic.

@matejk matejk added the cmake Related to cmake build system label Dec 4, 2024
@aleks-f
Copy link
Member Author

aleks-f commented Dec 6, 2024 •
edited
Loading

If there is a choice, I'd say better not to fail on current platforms, than fail for the sake of maintaining the old ones. <atomic> is 14 years old

@aleks-f aleks-f merged commit e2576ff into main Dec 7, 2024
74 checks passed
@matejk matejk deleted the 4806-libatomic branch December 11, 2024 15:21
@matejk
Copy link
Contributor

matejk commented Dec 11, 2024

Cherry-picked to poco-1.14.1.

@rtzoeller rtzoeller mentioned this pull request Jan 16, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejk matejk matejk approved these changes

Assignees
No one assigned
Labels
buildsystem cmake Related to cmake build system
Projects
1.14
Status: Done
Milestone
Release 1.14.1
Development

Successfully merging this pull request may close these issues.
2 participants
@aleks-f @matejk