Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interpolate_from_fr fun #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vihu
Copy link

@vihu vihu commented Jan 11, 2021

This is just a helper function I ended up writing while working on an erlang nif for threshold_crypto. Thought it may be helpful to merge upstream.

Copy link
Collaborator

@afck afck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this one: I don't think it's idiomatic in Rust to provide a Vec version for functions that take a slice.

If we add a generalization for convenience, I'd make it as general as possible, and actually modify compute_interpolation itself. It just iterates over the samples once anyway, so we could accept any T: IntoIterator where T::Item: Borrow<Fr>. That should make it accept vectors, slices and other iterators and collections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants