This repository was archived by the owner on Jun 29, 2020. It is now read-only.
(Improvement) Use pure/view instead of const on functions #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
fvictorio
approved these changes
May 30, 2018
phahulin
reviewed
May 30, 2018
| @@ -73,7 +73,7 @@ contract ProofOfPhysicalAddress { | |||
|
|
|||
| // Helpers: | |||
| function signerIsValid(bytes32 data, uint8 v, bytes32 r, bytes32 s) | |||
| public constant returns (bool) | |||
| public view returns (bool) | |||
There was a problem hiding this comment.
I think this one can be turned into pure
There was a problem hiding this comment.
Maybe, but if run the test using pure, the output is this below, and for that I used view instead of pure:
poa-popa on issue-#146 [$!] ⬢ v8.9.4
🦄 npm run test --prefix blockchain
> [email protected] test /Users/matiasgaratortiz/Github/poa-popa/blockchain
> NODE_ENV=test truffle test --network test
Using network 'test'.
Compiling ./contracts/ERC20.sol...
Compiling ./contracts/EthereumClaimsRegistryInterface.sol...
Compiling ./contracts/PhysicalAddressClaim.sol...
Compiling ./contracts/ProofOfPhysicalAddress.sol...
Compiling ./contracts/TestERC20.sol...
/Users/matiasgaratortiz/Github/poa-popa/blockchain/contracts/ProofOfPhysicalAddress.sol:80:49: TypeError: Function declared as pure, but this expression (potentially) reads from the environment or state and thus requires "view".
return (ecrecover(prefixed, v, r, s) == signer);
^----^
There was a problem hiding this comment.
Oh yes, I missed that it reads signer from contract state. Nevermind then
phahulin
approved these changes
May 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please provide the following information:
(Improvement)of existing functionalityPlease also put it into pull request title, e.g.
(Fix) confirmation page loadingWhat was the root cause of the problem originally / what feature was missing?
Some functions in smart-contracts were using const.
How does this pull request solve it (in broad terms)?
Replace const with pure/view
Does it close any open issues?
Closes (Refactor) Use pure/view instead of const on functions #146
Quick checklist
npm run lintshows no errorsAdditional information